Skip to content

Commit 282b191

Browse files
authored
fix(storage): api types (#1784)
1 parent a6394cd commit 282b191

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

packages/core/storage-js/src/lib/vectors/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,11 @@ export interface ListVectorBucketsOptions {
117117

118118
/**
119119
* Response from listing vector buckets
120-
* @property buckets - Array of bucket names
120+
* @property vectorBuckets - Array of bucket names
121121
* @property nextToken - Token for fetching next page (if more results exist)
122122
*/
123123
export interface ListVectorBucketsResponse {
124-
buckets: { vectorBucketName: string }[]
124+
vectorBuckets: { vectorBucketName: string }[]
125125
nextToken?: string
126126
}
127127

packages/core/storage-js/test/bucket-api.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,11 @@ describe('VectorBucketApi Integration Tests', () => {
106106
const response = await client.listBuckets()
107107

108108
const data = assertSuccessResponse(response)
109-
expect(data.buckets).toBeDefined()
110-
expect(Array.isArray(data.buckets)).toBe(true)
111-
expect(data.buckets.length).toBeGreaterThanOrEqual(2)
109+
expect(data.vectorBuckets).toBeDefined()
110+
expect(Array.isArray(data.vectorBuckets)).toBe(true)
111+
expect(data.vectorBuckets.length).toBeGreaterThanOrEqual(2)
112112

113-
const bucketNames = data.buckets.map((b) => b.vectorBucketName)
113+
const bucketNames = data.vectorBuckets.map((b) => b.vectorBucketName)
114114
expect(bucketNames).toContain(bucket1)
115115
expect(bucketNames).toContain(bucket2)
116116
})
@@ -128,9 +128,9 @@ describe('VectorBucketApi Integration Tests', () => {
128128
const response = await client.listBuckets({ prefix })
129129

130130
const data = assertSuccessResponse(response)
131-
expect(data.buckets.length).toBeGreaterThanOrEqual(2)
131+
expect(data.vectorBuckets.length).toBeGreaterThanOrEqual(2)
132132

133-
const bucketNames = data.buckets.map((b) => b.vectorBucketName)
133+
const bucketNames = data.vectorBuckets.map((b) => b.vectorBucketName)
134134
expect(bucketNames).toContain(bucket1)
135135
expect(bucketNames).toContain(bucket2)
136136
// bucket3 should not be included as it doesn't match prefix
@@ -145,9 +145,9 @@ describe('VectorBucketApi Integration Tests', () => {
145145
const response = await client.listBuckets({ maxResults: 1 })
146146

147147
const data = assertSuccessResponse(response)
148-
expect(data.buckets.length).toBeLessThanOrEqual(1)
148+
expect(data.vectorBuckets.length).toBeLessThanOrEqual(1)
149149

150-
if (data.buckets.length === 1 && data.nextToken) {
150+
if (data.vectorBuckets.length === 1 && data.nextToken) {
151151
expect(data.nextToken).toBeDefined()
152152
expect(typeof data.nextToken).toBe('string')
153153
}
@@ -159,7 +159,7 @@ describe('VectorBucketApi Integration Tests', () => {
159159
})
160160

161161
const data = assertSuccessResponse(response)
162-
expect(data.buckets).toEqual([])
162+
expect(data.vectorBuckets).toEqual([])
163163
expect(data.nextToken).toBeUndefined()
164164
})
165165
})

packages/core/storage-js/test/mock-server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ function handleListBuckets(body: any): MockResponse {
335335
return {
336336
status: 200,
337337
data: {
338-
buckets: buckets.slice(0, maxResults).map((name) => ({ vectorBucketName: name })),
338+
vectorBuckets: buckets.slice(0, maxResults).map((name) => ({ vectorBucketName: name })),
339339
nextToken: buckets.length > maxResults ? 'mock-next-token' : undefined,
340340
},
341341
}

0 commit comments

Comments
 (0)