Ensure getRawJsonObject returns data for constructed webhooks #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xavdid-stripe requested review from a team and jar-stripe and removed request for a team 
helenye-stripe approved these changes Feb 5, 2025
xavdid-stripe changed the title getRawJsonObject return data for constructed webhooksgetRawJsonObject returns data for constructed webhooks xavdid-stripe added a commit that referenced this pull request Feb 7, 2025
* Update generated code for v1461 * Update generated code for v1462 * Update generated code for v1463 * Updated upload artifact ci action (#1941) * Update generated code (#1936) * Update generated code for v1441 * Update generated code for v1455 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com> * Bump version to 28.3.0 * Update generated code for v1464 * Update generated code for v1466 * Update generated code for v1467 * Ensure `getRawJsonObject` returns data for constructed webhooks (#1946) * construct fake response during webhook parsing * formatting * Update generated code for v1472 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: prathmesh-stripe <165320323+prathmesh-stripe@users.noreply.github.com> Co-authored-by: helenye-stripe <111009531+helenye-stripe@users.noreply.github.com> Co-authored-by: Helen Ye <helenye@stripe.com> Co-authored-by: David Brownman <109395161+xavdid-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why?
StripeObjects make their raw JSON available viagetRawJsonObject(). But, that data is sourced from thelastResponse(the API call that created that object). Constructed webhooks don't have a last response, so that raw object was unavailable. This fixes that.What?
See Also
Event#getRawJsonObjectreturnsnullwhen constructed for webhook #1945