Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 1, 2023

Adds VS Code remote dev container support for those developers who use VS Code and containers for development.

  • It is configures to create container with Nodejs 18 LTS & Python 3.11
  • Post creation of the container it executes the essential commands in environment setup and build it, thus enabling quick and easy way to get everything setup for new contributors without context switching.
@squidfunk
Copy link
Owner

Thanks for the PR! Honestly, I'm not feeling comfortable maintaining this, because none of us maintainers uses dev containers. Are you up for maintaining this configuration for the time to come? If so, we can merge it. Additionally, could you please clean up the source files? There are a lot of commented out lines that seem very generic.

@ghost
Copy link
Author

ghost commented May 2, 2023

I can maintain it.

Comments are removed, @squidfunk.

@squidfunk
Copy link
Owner

Thanks! Yes, let's remove them. Folks who are using dev containers should consult the dev containers documentation, as commented-out is not executed and thus just rots ☺️ LGTM!

@squidfunk squidfunk merged commit 32b7ee9 into squidfunk:master May 2, 2023
@ghost ghost deleted the feature/add-remotedev-support branch May 2, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant