Fix regex for keyword arguments #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| oh it's called "keyword" and not "kwarg", right? are you sure??? o_O |
Contributor Author
| Yes, you ran it three times to be sure 😅 Amazingly enough I managed to point to the docs with state that as well, while still typing the wrong thing 🤦♂️ |
Contributor
| oh, this has to be merged correctly w the 0.5.3 bump |
Contributor
| or i forgot to push it....ugh |
Contributor Author
| Awesome, thanks a lot! Build is up here. Sorry again for the trouble! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Well, this is embarassing 😬 I had tested the changes by directly editing the corresponding file in my venv and then made this rookie mistake while copying the changes to my fork. I double checked again and this is now working as expected. I'm really sorry for the keyword :/