Improve the regex, require Node.js 8 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @sindresorhus Both fixes aren't possible without lookbehind assertions, which aren't available in Node.js v6 without |
Owner
| Awesome! :) |
Owner
| @stroncium This PR introduces catastrophic backtracking to the regex. Specifically this part I have worked around it for now, but it would be great if you could try to bring back the old functionality: 6baf2cc Playground: https://regex101.com/r/X20eYT/2 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added invalid strings from This regex is broken by design #14
Made regexp respect Semantic Versioning 2.0.0 clause 9
Made regexp to only respect boundaries to whitespace and beginnings/ends of strings
Changed older tests to not violate clause 9
'1.2.3-alpha.10.beta.0', '1.2.3-alpha.10.beta.0+build.unicorn.rainbow'became
'1.2.3-alpha.10.beta', '1.2.3-alpha.10.beta+build.unicorn.rainbow'Fixed
vprefix is not part of semver #7 while I was at it.[WIP] nodejs v6
Fixes #14
Fixes #7