Skip to content

Conversation

@mickvangelderen
Copy link
Contributor

My use case is to enable:

 #[cfg_attr(feature = "clap", arg(long))] // <- clap requires one of From<OsString>, ... , FromStr #[cfg_attr(feature = "serde", serde(default))] pub whatever: Option<serde_json::Map<String, serde_json::Value>>,

I could write a value_parser for clap:

fn parse_json_object(s: &str) -> Result< serde_json::Map<String, serde_json::Value>, String> { serde_json::from_str(s).map_err(|error| error.to_string()) }

But that probably isn't doing the best job with respect to error formatting.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines 274 to +275


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@dtolnay dtolnay merged commit 447170b into serde-rs:master Aug 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants