Skip to content

Commit d9e0728

Browse files
authored
fix: throw if where receives an invalid value (#15699)
1 parent 48d6193 commit d9e0728

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/dialects/abstract/query-generator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2833,7 +2833,7 @@ class QueryGenerator {
28332833
});
28342834
}
28352835

2836-
return '1=1';
2836+
throw new Error(`Unsupported where option value: ${util.inspect(smth)}. Please refer to the Sequelize documentation to learn more about which values are accepted as part of the where option.`);
28372837
}
28382838

28392839
// A recursive parser for nested where conditions
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
const { expect } = require('chai');
2+
const { sequelize } = require('../../support');
3+
4+
describe('QueryGenerator#getWhereConditions', () => {
5+
const queryGenerator = sequelize.queryInterface.queryGenerator;
6+
7+
it('throws if called with invalid arguments', () => {
8+
const User = sequelize.define('User');
9+
10+
expect(() => {
11+
queryGenerator.getWhereConditions(new Date(), User.getTableName(), User);
12+
}).to.throw('Unsupported where option value');
13+
});
14+
});

0 commit comments

Comments
 (0)