Micro-optimize NamePrettifier::prettifyTestMethodName() #5739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sebastianbergmann added type/performance 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #5739 +/- ## ========================================= Coverage 90.01% 90.01% Complexity 6493 6493 ========================================= Files 688 688 Lines 19714 19715 +1 ========================================= + Hits 17745 17746 +1 Misses 1969 1969 ☔ View full report in Codecov by Sentry. |
| Cherry-picked into |
sebastianbergmann changed the title NamePrettifier->prettifyTestMethodName()NamePrettifier::prettifyTestMethodName() Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the function call is showing up in blackfire profiles of
blackfire run php ./phpunit --testsuite unitafter the change it no longer appears