Skip to content

Conversation

jozic
Copy link
Contributor

@jozic jozic commented May 28, 2023

Recently stumbled on the fact that Regex#matches doesn't exist in 2.12
i had to change versionPolicyIntention to Compatibility.BinaryCompatible to get tests green. Mima newbie here, so don't kick me too hard here.

@jozic jozic marked this pull request as ready for review May 30, 2023 23:08
@jozic
Copy link
Contributor Author

jozic commented May 31, 2023

@SethTisue @xuwei-k could you please review and let workflow to run? Thank you!

@jozic
Copy link
Contributor Author

jozic commented Jun 9, 2023

is there anything else needs to happen before merge?

@SethTisue SethTisue merged commit 41e99c7 into scala:main Jun 10, 2023
@SethTisue
Copy link
Member

Thank you! I'll roll a release after we merge a few more.

mergify bot referenced this pull request in slick/slick Jun 16, 2023
…2.11.0 (#2749) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.scala-lang.modules:scala-collection-compat](http://www.scala-lang.org/) ([source](https://togithub.com/scala/scala-collection-compat)) | minor | `2.10.0` -> `2.11.0` | --- ### Release Notes <details> <summary>scala/scala-collection-compat</summary> ### [`v2.11.0`](https://togithub.com/scala/scala-collection-compat/releases/tag/v2.11.0): 2.11.0 [Compare Source](https://togithub.com/scala/scala-collection-compat/compare/v2.10.0...v2.11.0) #### What's Changed - Add `RegexOps` by [@&#8203;jozic](https://togithub.com/jozic) in [https://github.com/scala/scala-collection-compat/pull/595](https://togithub.com/scala/scala-collection-compat/pull/595) - Add implementation of distinctBy by [@&#8203;alexklibisz](https://togithub.com/alexklibisz) in [https://github.com/scala/scala-collection-compat/pull/602](https://togithub.com/scala/scala-collection-compat/pull/602) #### New Contributors - [@&#8203;jozic](https://togithub.com/jozic) made their first contribution in [https://github.com/scala/scala-collection-compat/pull/595](https://togithub.com/scala/scala-collection-compat/pull/595) - [@&#8203;alexklibisz](https://togithub.com/alexklibisz) made their first contribution in [https://github.com/scala/scala-collection-compat/pull/602](https://togithub.com/scala/scala-collection-compat/pull/602) **Full Changelog**: scala/scala-collection-compat@v2.10.0...v2.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/slick/slick). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjExNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants