Update WebGPU API to draft 2024-11-22 #4290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nolanderc force-pushed the webgpu-2024-11-22 branch 2 times, most recently from efa902f to f16e3bb Compare Contributor Author
| I don't know why one of the CI checks just failed ( |
nolanderc force-pushed the webgpu-2024-11-22 branch from f16e3bb to 779f011 Compare Contributor Author
| Just pushed the same commit again, and now it works. Definitely a flaky test. |
daxpedda requested changes Nov 28, 2024
Member
daxpedda left a comment
daxpedda left a comment There was a problem hiding this comment.
Some nits that I will push myself, otherwise LGTM.
Thank you!
daxpedda approved these changes Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Needed for gfx-rs/wgpu#6614