Restart WebDriver on failure #4267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, if starting the WebDriver process fails, the test runner simply spends its remaining timeout period trying to connect to the failed WebDriver process, which obviously doesn't work.
Instead this PR changes the behavior to continuously check if the WebDriver process didn't fail and only then wait until a connection is established. The timeout period remains 5 seconds in total.
I've tested this quite extensively now with
web-timeand I only got one unrelated failure. So this is a huge improvement from before, where almost every single CI run has failed.