Fixed generated types for getters and setters #4202
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While working on #4201, I had the idea to test how wasm bindgen handles getter-setter pairs with different types. Not well was the answer.
This PR completely changes how the type definitions for getters and setters are generated and fixes several bugs:
There were also some minor issues:
This PR fixes all of those issues and adds a test to verify correctness.
Fixing these issues is a requirement for #4188 and #4201.