Fixed 2 minor bugs in JS glue code #4192
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This separates the 2 bug fixes from #4189 into their own PR.
Changes:
debugString(this is the JS glue code version offormat!("{:?}", value)) had a bug where it checked for a regex mismatch incorrectly. This would lead to dereferencingnullat runtime, which throws aTypeError._assertClassreturnedinstance.ptr. Here's the full code of the function:Returning
instance.ptris weird for 2 reasons:_assertClassis only used in one place and its return value is ignored. As @daxpedda found out, the return value hasn't been used for 6 years now.ptrfield. Theptrfield was renamed to__wbg_ptrone year ago and this function wasn't updated.So I just removed the return statement and
instance.ptr.