Skip to content

Conversation

@axelkar
Copy link
Contributor

@axelkar axelkar commented Aug 7, 2024

See GH-983

@phimuemue

Is the wording okay? What about the explicit type definition?

@phimuemue
Copy link
Member

What about the explicit type definition?

We can use them where needed, otherwise elide them.

@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (6814180) to head (4313499).
Report is 116 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #984 +/- ## ========================================== - Coverage 94.38% 94.30% -0.08%  ========================================== Files 48 49 +1 Lines 6665 6712 +47 ========================================== + Hits 6291 6330 +39  - Misses 374 382 +8 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phimuemue phimuemue mentioned this pull request Aug 19, 2024
@phimuemue
Copy link
Member

phimuemue commented Aug 19, 2024

@axelkar Thanks for the update. There are some CI errors. Ours should have been fixed by 4f49f26. Could you rebase and fix yours if needed?

@phimuemue phimuemue enabled auto-merge August 24, 2024 20:04
auto-merge was automatically disabled August 24, 2024 21:25

Head branch was pushed to by a user without write access

@phimuemue phimuemue enabled auto-merge August 25, 2024 06:07
@phimuemue
Copy link
Member

Thanks.

@phimuemue phimuemue added this pull request to the merge queue Aug 26, 2024
Merged via the queue into rust-itertools:master with commit 91f9618 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants