Fix/ignore warnings within doctests #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #964 +/- ## ========================================== + Coverage 94.38% 94.51% +0.12% ========================================== Files 48 49 +1 Lines 6665 7072 +407 ========================================== + Hits 6291 6684 +393 - Misses 374 388 +14 ☔ View full report in Codecov by Sentry. |
phimuemue approved these changes Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#963 lead me to know about
#![doc(test(attr(...)))].Our doctests have some warnings that are ignored by default.
Here, I fix some, sometimes silently (comment out), and globally ignore
deprecatedandunstable_name_collisions.Maybe I should
allow(unused_variables)instead of many# let _ = ...;?