Skip to content

Conversation

rbruenig
Copy link
Contributor

@rbruenig rbruenig commented Jun 9, 2024

PR for improving documentation of tree_reduce, it will close #946

This PR only changes documentation and does not touch any actual code.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (6814180) to head (44a73c5).
Report is 100 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #955 +/- ## ========================================== + Coverage 94.38% 94.64% +0.26%  ========================================== Files 48 49 +1 Lines 6665 7065 +400 ========================================== + Hits 6291 6687 +396  - Misses 374 378 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbruenig
Copy link
Contributor Author

@Philippe-Cholet Is there anything that still should be improved or is this ready to be merged 🙂 ?

Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch and opened the doc to read it. The text is fine, only got 2 visual nitpicks. I'll merge once fixed, thanks for the remainder.

@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Jun 17, 2024
Merged via the queue into rust-itertools:master with commit a0225ce Jun 17, 2024
@Philippe-Cholet
Copy link
Member

Thanks for the needed clarification!

@Philippe-Cholet Philippe-Cholet added this to the next milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants