Fix into_group_map_by documentation errors #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This method returns a HashMap, not an Iterator. Bonus whitespace fix in example. See also the `into_group_map` documentation.
| Thank you. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1000 +/- ## ========================================== - Coverage 94.38% 94.38% -0.01% ========================================== Files 48 49 +1 Lines 6665 6769 +104 ========================================== + Hits 6291 6389 +98 - Misses 374 380 +6 ☔ View full report in Codecov by Sentry. |
phimuemue approved these changes Dec 5, 2024
Merged via the queue into rust-itertools:master with commit Dec 5, 2024
f80883b 9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This method returns a HashMap, not an Iterator.
Bonus whitespace fix in example.
See also the
into_group_mapdocumentation.