Fix a false positive for RSpec/ExampleWithoutDescription when specify with multi-line block and missing description #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
12 tasks
pirj reviewed Feb 16, 2024
ydah force-pushed the fix-false-positive-example-without-description branch 2 times, most recently from 7ca2e33 to 614c7ab Compare 
…ify` with multi-line block and missing description This PR fixes a false positive for `RSpec/ExampleWithoutDescription` when `specify` with multi-line block and missing description. This is because `specify` is recommended when there is no description. refs: https://rspec.rubystyle.guide/#it-and-specify ```ruby specify do # ... end ```
ydah force-pushed the fix-false-positive-example-without-description branch from 614c7ab to 20311f5 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive for
RSpec/ExampleWithoutDescriptionwhenspecifywith multi-line block and missing description. This is becausespecifyis recommended when there is no description.refs: https://rspec.rubystyle.guide/#it-and-specify
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).