Fix false negatives for Rails/RedundantActiveRecordAllMethod when methods in POSSIBLE_ENUMERABLE_BLOCK_METHODS are used in a block.

Author: masato-bkn

changelog/fix_fix_false_negatives_for_ rails_redundant_active_record_all_method.md

@@ -0,0 +1 @@
+* [#1382](https://github.com/rubocop/rubocop-rails/pull/1382): Fix false negatives for `Rails/RedundantActiveRecordAllMethod` when methods in `POSSIBLE_ENUMERABLE_BLOCK_METHODS` are used in a block. ([@masato-bkn][])

lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -174,7 +174,7 @@ def possible_enumerable_block_method?(node)
  parent = node.parent
  return false unless POSSIBLE_ENUMERABLE_BLOCK_METHODS.include?(parent.method_name)
 
- parent.parent&.block_type? || parent.parent&.numblock_type? || parent.first_argument&.block_pass_type?
+ parent.block_node || parent.first_argument&.block_pass_type?
  end
 
  def sensitive_association_method?(node)

spec/rubocop/cop/rails/redundant_active_record_all_method_spec.rb

@@ -334,6 +334,13 @@
  User.all.#{method}(&:do_something)
  RUBY
  end
+
+ it "registers an offense when using `#{method}` in block" do
+ expect_offense(<<~RUBY)
+ do_something { User.all.#{method} }
+ ^^^ Redundant `all` detected.
+ RUBY
+ end
  end
  end