Skip to content

Fix the old import indexDefinition -> index_definition #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

Fix the old import indexDefinition -> index_definition #3652

merged 2 commits into from
May 23, 2025

Conversation

@ShubhamKaudewar
Copy link
Contributor

Fix the old import indexDefinition -> index_definition

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.
@ShubhamKaudewar
Update search_json_examples.ipynb
5d6c324 
Fix the old import indexDefinition -> index_definition
@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label May 22, 2025
petyaslavova
petyaslavova approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@petyaslavova petyaslavova merged commit 9450363 into redis:master May 23, 2025
37 checks passed
ManelCoutinhoSensei pushed a commit to ManelCoutinhoSensei/redis-py that referenced this pull request Jun 30, 2025
@ShubhamKaudewar @ManelCoutinhoSensei
Update search_json_examples.ipynb: Fix the old import indexDefinition…
3da3b9a 
… -> index_definition (redis#3652) Fix the old import indexDefinition -> index_definition
ManelCoutinhoSensei pushed a commit to ManelCoutinhoSensei/redis-py that referenced this pull request Jul 1, 2025
@ShubhamKaudewar @ManelCoutinhoSensei
Update search_json_examples.ipynb: Fix the old import indexDefinition…
33a6db7 
… -> index_definition (redis#3652) Fix the old import indexDefinition -> index_definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

2 participants

@ShubhamKaudewar @petyaslavova