Skip to content

Marks old RediSearch 1.0 commands as deprecated #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

Marks old RediSearch 1.0 commands as deprecated #3606

merged 5 commits into from
Apr 24, 2025

Conversation

@elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Apr 17, 2025 •
edited
Loading

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is the new or changed code fully tested?
  • Is there an example added to the examples folder (if applicable)?

Description of change

The FT.DEL and FT.MGET commands are not supported in RediSearch 2.0+. Most of the other RediSearch 1.0-speific commands had already been marked as deprecated, I'm guessing these two were missed.

TODO: Check if we need to document the deprecation.
@elena-kolevska elena-kolevska marked this pull request as draft April 17, 2025 14:22
@elena-kolevska elena-kolevska marked this pull request as ready for review April 24, 2025 10:33
petyaslavova
petyaslavova approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@petyaslavova petyaslavova merged commit 77e8db2 into redis:master Apr 24, 2025
37 checks passed
petyaslavova pushed a commit that referenced this pull request Apr 29, 2025
@elena-kolevska @petyaslavova
Marks old RediSearch 1.0 commands as deprecated (#3606)
1bc1b86 
* Marks old RediSearch 1.0 commands as deprecated * linters
petyaslavova pushed a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
@elena-kolevska @petyaslavova
Marks old RediSearch 1.0 commands as deprecated (redis#3606)
f5d5ff3 
* Marks old RediSearch 1.0 commands as deprecated * linters
ManelCoutinhoSensei pushed a commit to ManelCoutinhoSensei/redis-py that referenced this pull request Jun 30, 2025
@elena-kolevska @ManelCoutinhoSensei
Marks old RediSearch 1.0 commands as deprecated (redis#3606)
90316bc 
* Marks old RediSearch 1.0 commands as deprecated * linters
ManelCoutinhoSensei pushed a commit to ManelCoutinhoSensei/redis-py that referenced this pull request Jul 1, 2025
@elena-kolevska @ManelCoutinhoSensei
Marks old RediSearch 1.0 commands as deprecated (redis#3606)
d8f1865 
* Marks old RediSearch 1.0 commands as deprecated * linters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation

2 participants

@elena-kolevska @petyaslavova