Skip to content

Fixing typing for FCALL commands to match PEP 484 #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fixing typing for FCALL commands to match PEP 484 #3537

merged 2 commits into from
Feb 28, 2025

Conversation

@vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #3536
@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Feb 28, 2025
@petyaslavova petyaslavova merged commit 577b4ac into master Feb 28, 2025
37 checks passed
@petyaslavova petyaslavova deleted the vv-fix-fcall-incorrect-typing branch February 28, 2025 15:16
petyaslavova pushed a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
@vladvildanov @petyaslavova
Fixing typing for FCALL commands to match PEP 484 (redis#3537)
77193ce 
* Fixing typing for FCALL commands to match PEP 484 * Codestyle fixes * Fixes issue redis#3536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange API or Breaking Change

2 participants

@vladvildanov @petyaslavova