Skip to content

Conversation

@Yard1
Copy link
Contributor

@Yard1 Yard1 commented Jan 10, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes PING failing in health check due to async connection on_connect if protocol != 2 by following the pattern already applied in other if...else branches in on_connect.

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is reproducible when a value >0 is set for health_check_interval argument when the sync and async clients are created.

@petyaslavova petyaslavova added the bug Bug label Feb 27, 2025
@petyaslavova petyaslavova changed the title Fix async connection health check for protocol != 2 Fix connection health check for protocol != 2 when auth credentials are provided and health check interval is configured Mar 4, 2025
@petyaslavova petyaslavova merged commit b9af374 into redis:master Mar 5, 2025
37 checks passed
petyaslavova pushed a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
…re provided and health check interval is configured (redis#3477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug

2 participants