Skip to content

Conversation

rbs333
Copy link
Contributor

@rbs333 rbs333 commented Oct 8, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR adds support for setting the scorer with an aggregate call and resolves issue #3408.

@dmaier-redislabs
Copy link
Contributor

Hi Robert,

we are going to review this PR next week when @vladvildanov is back.

Regards,
David

@tylerhutcherson
Copy link
Contributor

Hi Robert,

we are going to review this PR next week when @vladvildanov is back.

Regards,

David

Thanks @dmaier-redislabs @vladvildanov let me or Robert know if you need anything else, happy to help! Cheers.

@rbs333
Copy link
Contributor Author

rbs333 commented Oct 16, 2024

Pushed a isort/typing fix that should hopefully resolve CI if we could approve the workflow to see @dmaier-redislabs @vladvildanov

@vladvildanov
Copy link
Collaborator

@rbs333 Hi! The following tests are failing

@rbs333
Copy link
Contributor Author

rbs333 commented Oct 21, 2024

@vladvildanov
Copy link
Collaborator

@rbs333 Left a comment after detailed review

@vladvildanov vladvildanov merged commit 00f5be4 into redis:master Oct 22, 2024
55 checks passed
@rbs333 rbs333 deleted the feat/iss-3408/add-scorer-aggregate branch October 28, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants