- Notifications
You must be signed in to change notification settings - Fork 2.6k
Replace flake8+isort+black with ruff #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@ ## master #3147 +/- ## ======================================= Coverage 91.84% 91.84% ======================================= Files 128 128 Lines 33232 33272 +40 ======================================= + Hits 30523 30560 +37 - Misses 2709 2712 +3 ☔ View full report in Codecov by Sentry. |
47822c3 to 0fba9cd Compare | Rebased. Looks like @gerzse is on the move here, care to take a look? |
| Rebased. cc @gerzse. |
| Rebased. cc @vladvildanov (since you seem to be active on this repo). |
d81997a to a0acc62 Compare b1d6efe to 2e32405 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akx There is a conflict in one of the files. Can you please fix it?
| @petyaslavova Conflict fixed. I also moved the configuration to pyproject.toml now that it's a thing, and made it more granular. Some of the non-free Redis modules' command modules don't adhere to usual Python naming, so they're excluded from the naming convention checks. |
* Replace flake8 + isort + flynt with ruff * Replace black with `ruff format`; run it
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR replaces the use of
flake8,isort, andblackwith Ruff.More ruff rules could (should) be enabled later and the
noqas taken care of.