Skip to content

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Sep 20, 2023

This PR contains a series of type hint improvements. While it still doesn't complete coverage, we've at least moved the ball forward a bit

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Sep 20, 2023
@chayim chayim requested a review from dvora-h September 20, 2023 12:28
@chayim chayim marked this pull request as draft September 20, 2023 12:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 99.42% and no project coverage change.

Comparison is base (ded9f7c) 91.37% compared to head (c080909) 91.37%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2952 +/- ## ======================================= Coverage 91.37% 91.37% ======================================= Files 126 126 Lines 32603 32608 +5 ======================================= + Hits 29790 29796 +6  + Misses 2813 2812 -1 
Files Changed Coverage Δ
redis/_parsers/base.py 90.83% <ø> (ø)
redis/_parsers/resp3.py 47.55% <0.00%> (ø)
redis/asyncio/connection.py 83.92% <ø> (+0.33%) ⬆️
redis/cluster.py 92.81% <ø> (ø)
redis/commands/json/commands.py 89.55% <ø> (ø)
redis/commands/search/__init__.py 72.41% <ø> (ø)
redis/commands/search/field.py 98.64% <ø> (ø)
tests/test_asyncio/test_cwe_404.py 100.00% <ø> (ø)
tests/test_asyncio/test_json.py 99.78% <ø> (ø)
tests/test_asyncio/test_lock.py 99.48% <ø> (ø)
... and 23 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim marked this pull request as ready for review September 21, 2023 07:33
chayim and others added 15 commits September 21, 2023 11:43
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
@chayim chayim requested a review from dvora-h September 21, 2023 10:04
@dvora-h dvora-h merged commit 2ee7c3c into master Sep 21, 2023
@dvora-h dvora-h deleted the ck-typing branch September 21, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants