Skip to content

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Aug 17, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@uglide uglide requested review from chayim and dvora-h August 17, 2023 13:26
@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (6968431) 91.27% compared to head (d325804) 91.26%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2896 +/- ## ========================================== - Coverage 91.27% 91.26% -0.01%  ========================================== Files 126 126 Lines 32368 32368 ========================================== - Hits 29544 29542 -2  - Misses 2824 2826 +2 

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h dvora-h merged commit 53be0b6 into master Sep 11, 2023
@dvora-h dvora-h deleted the uglide-add-72-support-in-readme branch September 11, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants