Skip to content

Conversation

@ccjmne
Copy link
Contributor

@ccjmne ccjmne commented Jun 27, 2022

Summary of fixes:

# Extraneous "the" -and the the return type +and the return type # "little-used" is the proper adjective -a little used feature +a little-used feature # "into" is the proper preposition -convert any `Observable` in to a `Promise` +convert any `Observable` into a `Promise` # Operators use the code highlight everywhere else -Calling takeLast without +Calling `takeLast` without # "in line with" is the proper locution (in two places) -This puts us in-line with +This puts us in line with # Past participle expected here -handling is use +handling is used # ... and there -information was send +information was sent # Typo: "to" instead of "two" -the equality of to observables +the equality of two observables
Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@jakovljevic-mladen jakovljevic-mladen merged commit 7331b15 into ReactiveX:master Mar 27, 2023
jakovljevic-mladen pushed a commit that referenced this pull request Mar 27, 2023
@jakovljevic-mladen
Copy link
Member

jakovljevic-mladen commented Mar 27, 2023

Thanks for the fix. It is cherry-picked to 7.x branch and deployed to the rxjs.dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants