Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 6, 2025

Vision has already using VS2022 in its build, so this PR will just clean up any remaining reference to VS2019

@huydhn huydhn requested review from Camyll and atalman February 6, 2025 20:12
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8901

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit f96ad6f with merge base d4a1e3d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn huydhn merged commit fab1188 into pytorch:main Feb 7, 2025
62 of 67 checks passed
@github-actions
Copy link

github-actions bot commented Feb 7, 2025

Hey @huydhn!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jul 9, 2025
Reviewed By: scotts Differential Revision: D77997078 fbshipit-source-id: 99b403a1b1ab2dd5636eab5dd843d5bfa43d0543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants