Revamp setup.py and C++ extension build #8528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8528
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 46f1189 with merge base 0bf8d14 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| Everything is passing in f5c1b36 except for some flaky macos value assertions. |
| Every single job is passing except for |
| Hey @NicolasHug! You merged this PR, but no labels were added. |
facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2024
Reviewed By: vmoens Differential Revision: D60596220 fbshipit-source-id: 7b8010a1d5955028b8e764146e3e4ae785f49269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR completely re-write our setup.py to be more modular, manageable and modern. This is needed in order to add more decoders / C dependencies like for webp decoding in #8527.
I am revamping everything EXCEPT for the 2 video decoder extensions - no thanks.