Skip to content

Conversation

@vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Mar 6, 2024

Follow-up to #8279

Description:

  • Added missing JPEG_FOUND flag in exif.h to properly handle situations when jpg is not present on the system
  • Replaced std::vector with a reader (inspired from PNG decoder code)
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8302

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 64166d0 with merge base f3298dc (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5 vfdev-5 changed the title Added missing JPEG_FOUND flag to EXIF Improved jpeg decoding code with exif Mar 6, 2024
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vfdev-5 , one Q below but I'll let you decide on it, LGTM

@vfdev-5 vfdev-5 merged commit fd9b61d into pytorch:main Mar 6, 2024
@vfdev-5 vfdev-5 deleted the fix-jpg-exif branch March 6, 2024 12:13
@github-actions
Copy link

github-actions bot commented Mar 6, 2024

Hey @vfdev-5!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
Reviewed By: vmoens Differential Revision: D55062784 fbshipit-source-id: da48223545c60feff80325f1b1b5e0d8ab6fc455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment