Skip to content

Conversation

@vilktor370
Copy link
Contributor

@vilktor370 vilktor370 commented Sep 21, 2023

  • Fixed the doc error for Gaussian Blur
  • Run build commands to ensure the code and doc builds.
  • Run style checks as specified in the CONTRIBUTING.md
  • No unit tests are run because only modified a comment.

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7978

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @vilktor370!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@vilktor370
Copy link
Contributor Author

vilktor370 commented Sep 21, 2023

Test result

image
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vilktor370.

@vilktor370 vilktor370 requested a review from pmeier September 21, 2023 11:53
pmeier
pmeier previously approved these changes Sep 21, 2023
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vilktor370!

@pmeier pmeier dismissed their stale review September 21, 2023 12:49

functional docstring

Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vilktor370 Sorry, I forgot that we need to fix the functional API as well:

"""Performs Gaussian blurring on the image by given kernel.
If the image is torch Tensor, it is expected
to have [..., H, W] shape, where ... means an arbitrary number of leading dimensions.

Could you apply the same patch there.

@vilktor370
Copy link
Contributor Author

@pmeier

I just pushed the changes for functional.py. Could you review it again?

@vilktor370 vilktor370 requested a review from pmeier September 21, 2023 19:49
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@pmeier pmeier merged commit cb512ea into pytorch:main Sep 22, 2023
@vilktor370 vilktor370 deleted the torchvision/fix-issue-7911 branch September 22, 2023 23:37
facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: matteobettini Differential Revision: D49600790 fbshipit-source-id: f598721349fc6d60a61b35f04b7dd3001e596fd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment