Fix isinstance with explicit (non generic) type alias #18512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a partial revert of python#18173 to unblock the 1.15 release Fixes python#18488
Contributor
| According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
brianschubert approved these changes Jan 23, 2025
Member
brianschubert left a comment
brianschubert left a comment There was a problem hiding this comment.
Fine by me! Thanks for doing this to unblock the release.
Collaborator Author
| Thanks for the review and for the original change! |
wesleywright pushed a commit that referenced this pull request Jan 23, 2025
5 tasks
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
This is a partial revert of python#18173 to unblock the 1.15 release Fixes python#18488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #18173 to unblock the 1.15 release
Fixes #18488