Improve performance of asdict in the common case

[eendebakpt]

Summary

We improve performance of attrs.asdict by:

• Using a fast check for atomic types (list int, float or str)
• Using issubclass instead of isinstance for various type checks

Benchmark:

asdict: Mean +- std dev: [main] 4.07 us +- 0.41 us -> [pr] 2.48 us +- 0.21 us: 1.64x faster Benchmark hidden because not significant (1): instance creation Geometric mean: 1.28x faster 

Test script

import pyperf setup = """ from attrs import define, asdict @define class Simple: i : int s : str l : list s = Simple(10, 'hi', [3, 1, 4]) """ runner = pyperf.Runner() runner.timeit(name="instance creation", stmt="Simple(10, 'hi', [3, 1, 4])", setup=setup) runner.timeit(name="asdict", stmt="asdict(s)", setup=setup) 

Notes:

• a similar PR was added to cpython dataclasses as well gh-103000: Optimise dataclasses asdict/astuple for common types python/cpython#103005
• With a similar approach we can improve performance of astuple. That is left to a separate PR though. Also see attrs.astuple() leaves performance on the table compared to operator.attrgetter #1129

Pull Request Check List

• Do not open pull requests from your main branch – use a separate branch!
  • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
  • This is not a pre-requisite for your pull request to be accepted, but you have been warned.
• Added tests for changed code.
  Our CI fails if coverage is not 100%.
• New features have been added to our Hypothesis testing strategy.
• Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
  • ...and used in the stub test file tests/typing_example.py.
  • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
• Updated documentation for changed code.
  • New functions/classes have to be added to docs/api.rst by hand.
  • Changes to the signatures of @attr.s() and @attrs.define() have to be added by hand too.
  • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
    The next version is the second number in the current release + 1.
    The first number represents the current year.
    So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
    If the next version is the first in the new year, it'll be 23.1.0.
    • If something changed that affects both attrs.define() and attr.s(), you have to add version directives to both.
• Documentation in .rst and .md files is written using semantic newlines.
• Changes (and possible deprecations) have news fragments in changelog.d.
• Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

[codspeed-hq]

CodSpeed Performance Report

Merging #1463 will improve performances by ×2.6

_{Comparing eendebakpt:asdict_atomic_types (080dbc5) with main (5d216e6)¹}

Summary

⚡ 2 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	test_asdict_atomic	16.3 ms	6.4 ms	×2.6
⚡	test_asdict_complicated	13.8 ms	9.5 ms	+45.6%

Footnotes

1. No successful run was found on main (57f0d54) during the generation of this report, so 5d216e6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[hynek]

Thanks!