Make validators optional in deep_mapping #1448
Merged
+82 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hynek commented Jul 27, 2025
| mapping_validator = attrib(default=None, validator=optional(is_callable())) | ||
| key_validator = attrib(validator=optional(is_callable())) | ||
| value_validator = attrib(validator=optional(is_callable())) | ||
| mapping_validator = attrib(validator=optional(is_callable())) |
Member Author
There was a problem hiding this comment.
This default made not sense given that _DeepMapping is private and only to be constructed by ourselves.
Yes, does indeed 🎉 Thanks for fixing! |
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Jul 29, 2025
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Oct 7, 2025
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Oct 7, 2025
Now fixed upstream in the new `attrs` version. * python-attrs/attrs#1448 * python-attrs/attrs#1449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1246
doesn't it @AdrianSosic?