Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False) #12959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
psf-chronographer bot added the bot:chronographer:provided 
leonarduschen changed the title 
leonarduschen commented Nov 14, 2024
leonarduschen commented Nov 14, 2024
nicoddemus approved these changes Nov 21, 2024
Member
nicoddemus left a comment
nicoddemus left a comment There was a problem hiding this comment.
LGTM, thanks for the PR, appreciate it!
Member
| Thanks @leonarduschen! Will squash/merge in a few days to give others a chance to review it. 👍 |
Contributor Author
| Sure thing @nicoddemus, thanks for the review! Excited for my first contribution :) |
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #12990 🤖 @patchback |
patchback bot pushed a commit that referenced this pull request Nov 25, 2024
- When `ReprEntry.style == "value"` (happens when calling `pytest.fail(..., pytrace=False)`, the message should not be printed to terminal using `TerminalWriter._write_source` because then it'll try to highlight the message as source code - The message should be printed to terminal directly using `TerminalWriter.line` or `TerminalWriter.write`, I went with the later for testing purposes #12959 (comment) Closes #12849 (cherry picked from commit 76e0444)
6 tasks
nicoddemus pushed a commit that referenced this pull request Nov 25, 2024
- When `ReprEntry.style == "value"` (happens when calling `pytest.fail(..., pytrace=False)`, the message should not be printed to terminal using `TerminalWriter._write_source` because then it'll try to highlight the message as source code - The message should be printed to terminal directly using `TerminalWriter.line` or `TerminalWriter.write`, I went with the later for testing purposes #12959 (comment) Closes #12849 (cherry picked from commit 76e0444) Co-authored-by: Leonardus Chen <leonardus.chen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #12849
Description:
ReprEntry.style == "value"(happens when callingpytest.fail(..., pytrace=False), the message should not be printed to terminal usingTerminalWriter._write_sourcebecause then it'll try to highlight the message as source codeTerminalWriter.lineorTerminalWriter.write, I went with the later for testing purposes Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False) #12959 (comment)closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.