Consider KeyboardInterrupt/SystemExit at collection time #12191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
anitahammer commented Apr 6, 2024
anitahammer commented 
for more information, see https://pre-commit.ci
nicoddemus requested changes Apr 7, 2024
There was a problem hiding this comment.
Thanks @anitahammer indeed this is a much better UX.
Could you please also:
- Add a test for this to ensure we do not regress in the future. Probably a simple way to simulate this is to make a module raise
KeyboardInterruptduring import and check that the session was interrupted and the message!!! KeyboardInterrupt !!!!!!!!!showed up. - Add a CHANGELOG entry
- Add yourself to
AUTHORS(optional)
| Thank you for the feedback @nicoddemus ! I've added a test case and verified that it was failing before my changes. |
RonnyPfannschmidt changed the title | Hi @nicoddemus |
nicoddemus reviewed May 2, 2024
| Thanks @anitahammer for the ping! |
nicoddemus approved these changes May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.