Skip to content

Conversation

@fahhem
Copy link
Contributor

@fahhem fahhem commented Dec 23, 2024

Changes a couple places to check asyncio_mode (cheap) before _is_asyncio_fixture_function

To fix #720

@fahhem
Copy link
Contributor Author

fahhem commented Dec 23, 2024

Might also close #997

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.42%. Comparing base (38ac413) to head (d5658f5).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
pytest_asyncio/plugin.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #1020 +/- ## ======================================= Coverage 91.42% 91.42% ======================================= Files 2 2 Lines 548 548 Branches 72 72 ======================================= Hits 501 501 Misses 28 28 Partials 19 19 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov
Copy link
Contributor

LGTM in general.
Could you please tune the title to stress the PR main intention: it speed-ups test collection for very large code base.
The title will be a part of changelog at the end.

@fahhem fahhem changed the title Check asyncio_mode (cheap) before _is_asyncio_fixture_function Speed-up test collection for larger codebases Dec 23, 2024
@fahhem
Copy link
Contributor Author

fahhem commented Dec 23, 2024

done, thanks!

@asvetlov asvetlov added this pull request to the merge queue Dec 30, 2024
Merged via the queue into pytest-dev:main with commit c99fe57 Dec 30, 2024
15 checks passed
@asvetlov
Copy link
Contributor

Thanks!

seifertm added a commit that referenced this pull request Dec 31, 2024
@seifertm
Copy link
Contributor

We currently don't have a mechanism that automatically updates the changelog when a PR is merged.
Therefore I added a corresponding changelog entry for this patch in a4e82ab

@seifertm seifertm added this to the v0.25 milestone Dec 31, 2024
@fahhem fahhem deleted the patch-1 branch December 31, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants