Mention in the docs that reusable workflows aren't supported right now

[virtuald]

Reusable workflows don't work, and it's challenging to know that. Help the user out.

[webknjaz]

@woodruffw thoughts?

[virtuald]

Also added a note to the README. I spent two hours trying to figure out why it wasn't working, hopefully this will save someone else some time.

[woodruffw]

@woodruffw thoughts?

I'm a slight 👎 on unconditionally spitting out this warning: in many cases, it'll unnecessarily confuse users who are trying to debug trusted publishers that are failing for other reasons.

That being said: maybe we could render it conditionally? Perhaps if we can somehow detect that the context is a reusable workflow?

[virtuald]

Well even if the error isn't output, it does seem like it would be good to put in the README since it's all like "The only good and righteous way to publish to pypi via github actions is through trusted publishing".. which doesn't work.

FWIW, I hadn't seen the troubleshooting section of the documentation at all, but good to know it's there.

[virtuald]

I'm a slight 👎 on unconditionally spitting out this warning

Fine, what about just putting a link to the troubleshooting page then?

[woodruffw]

Well even if the error isn't output, it does seem like it would be good to put in the README since it's all like "The only good and righteous way to publish to pypi via github actions is through trusted publishing".. which doesn't work.

This snark isn't necessary: everybody here is trying their best to help resolve your issue, and nobody's goal is to waste your time (or anyone else's). We've tried our best to document trusted publishing's limitations in public places.

Fine, what about just putting a link to the troubleshooting page then?

This seems reasonable to me. I prefer error specialization wherever possible, but linking to the overall troubleshooting page is a reasonable stop-gap until we figure out the right way to detect that we're in a reusable workflow.

[woodruffw]

LGTM!