Ignore quantifiers when splitting comma-separated regexes #8898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Do not split on commas if they are between braces, since that indicates a quantifier. Also added a protection for slow implementations since existing workarounds may result in long strings of chained regular expressions.
Overkill, slows down unit tests Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
jacobtylerwalls added Bug 🪲 Configuration 
This comment has been minimized.
This comment has been minimized.
Codecov Report
Additional details and impacted files
@@ Coverage Diff @@ ## main #8898 +/- ## ========================================== - Coverage 95.88% 95.88% -0.01% ========================================== Files 173 173 Lines 18552 18570 +18 ========================================== + Hits 17789 17806 +17 - Misses 763 764 +1
|
This comment has been minimized.
This comment has been minimized.
mbyrnepr2 reviewed Jul 30, 2023
mbyrnepr2 previously approved these changes Jul 30, 2023
Member Author
| I'm going to revert the unrelated doc/news updates from fdd914a, because that will stop this from backporting cleanly. |
This reverts commit fdd914a.
mbyrnepr2 reviewed Jul 30, 2023
| r"""Split a comma-separated list of regexps, taking care to avoid splitting | ||
| a regex employing a comma as quantifier, as in `\d{1,2}`.""" | ||
| if isinstance(value, (list, tuple)): | ||
| yield from value |
Member
There was a problem hiding this comment.
Codecov message looks important since that line yields a value and apparently isn’t covered?
Member Author
There was a problem hiding this comment.
No current code path sends a list of strings to this util, or the one above it (also missing coverage for the analogous line). Should we just delete these lines? Not certain--I think it makes sense to let this util be this permissive. Also helps guard against unexpected input. I'm inclined to leave as is. WDYT?
Member
There was a problem hiding this comment.
I think taking the time to try to understand is not worth it vs just not touching it.
Contributor
| 🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 4de6f9d |
Contributor
| The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-maintenance/2.17.x maintenance/2.17.x # Navigate to the new working tree cd .worktrees/backport-maintenance/2.17.x # Create a new branch git switch --create backport-8898-to-maintenance/2.17.x # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 d28def9f9eb5e55d3571b53b11f42e4142d53167 # Push it to GitHub git push --set-upstream origin backport-8898-to-maintenance/2.17.x # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-maintenance/2.17.xThen, create a pull request where the |
jacobtylerwalls added a commit to jacobtylerwalls/pylint that referenced this pull request Jul 30, 2023
…#8898) Do not split on commas if they are between braces, since that indicates a quantifier. Also added a protection for slow implementations since existing workarounds may result in long strings of chained regular expressions. Adjust existing test for invalid regex to be truly invalid Co-authored-by: lihu <lihu.ben-ezri-ravin@portalinstruments.com> (cherry picked from commit d28def9)
jacobtylerwalls added a commit that referenced this pull request Jul 30, 2023
) Do not split on commas if they are between braces, since that indicates a quantifier. Also added a protection for slow implementations since existing workarounds may result in long strings of chained regular expressions. Adjust existing test for invalid regex to be truly invalid Co-authored-by: lihu <lihu.ben-ezri-ravin@portalinstruments.com> (cherry picked from commit d28def9)
mbyrnepr2 pushed a commit to mbyrnepr2/pylint that referenced this pull request Aug 3, 2023
…#8898) Do not split on commas if they are between braces, since that indicates a quantifier. Also added a protection for slow implementations since existing workarounds may result in long strings of chained regular expressions. Adjust existing test for invalid regex to be truly invalid Co-authored-by: lihu <lihu.ben-ezri-ravin@portalinstruments.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successor to #7241 with cosmetic updates applied and merge conflicts/tests fixed.