Skip to content

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 16, 2025

Description

Let's see if it works.

Refs #10563

@cdce8p cdce8p added Documentation 📗 Skip news 🔇 This change does not require a changelog entry labels Sep 16, 2025
@cdce8p cdce8p linked an issue Sep 16, 2025 that may be closed by this pull request
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.89%. Comparing base (96f6b9c) to head (2d35a30).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## main #10564 +/- ## ======================================= Coverage 95.89% 95.89% ======================================= Files 176 176 Lines 19416 19416 ======================================= Hits 18619 18619 Misses 797 797 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I envision a pre-commit check where we check "words with dashes" against the message store and a pyenchant dict and then check that :ref: is present.

@cdce8p
Copy link
Member Author

cdce8p commented Sep 16, 2025

I envision a pre-commit check where we check "words with dashes" against the message store and a pyenchant dict and then check that :ref: is present.

Sounds good to me but might be tricky to implement. At least there are some edge cases which will need to be considered. Feel free to work on it if you're interested. I'll need to get back to the match performance improvements. Spend way to much time on this one today 😅

Do we want to merge this PR as is as a POC? And if so, should we backport it. If not, I can go ahead and close it.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure !

@cdce8p cdce8p merged commit aa5adbf into pylint-dev:main Sep 16, 2025
32 checks passed
@cdce8p cdce8p deleted the docs-test-refs branch September 16, 2025 20:55
pylint-backport bot pushed a commit that referenced this pull request Sep 16, 2025
cdce8p added a commit that referenced this pull request Sep 16, 2025
(cherry picked from commit aa5adbf) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport maintenance/3.3.x Documentation 📗 Skip news 🔇 This change does not require a changelog entry
2 participants