BUG: Make embedding files not break PDF/A-3 compliance #3472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #3472 +/- ## ======================================= Coverage 97.07% 97.07% ======================================= Files 56 56 Lines 9614 9615 +1 Branches 1742 1741 -1 ======================================= + Hits 9333 9334 +1 Misses 168 168 Partials 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan6419846 added a commit that referenced this pull request Sep 28, 2025
## What's new ### Bug Fixes (BUG) - Insert new embedded files in a sorted manner (#3477) by @stefan6419846 - Fix name tree handling for embedded files with Kids-based inputs (#3475) by @stefan6419846 - Make embedding files not break PDF/A-3 compliance (#3472) by @stefan6419846 ### Documentation (DOC) - Document AFRelationship handling for PDF/A and provide constants (#3478) by @stefan6419846 [Full Changelog](6.1.0...6.1.1)
OpenNingia pushed a commit to OpenNingia/pypdf that referenced this pull request Oct 23, 2025
OpenNingia pushed a commit to OpenNingia/pypdf that referenced this pull request Oct 23, 2025
## What's new ### Bug Fixes (BUG) - Insert new embedded files in a sorted manner (py-pdf#3477) by @stefan6419846 - Fix name tree handling for embedded files with Kids-based inputs (py-pdf#3475) by @stefan6419846 - Make embedding files not break PDF/A-3 compliance (py-pdf#3472) by @stefan6419846 ### Documentation (DOC) - Document AFRelationship handling for PDF/A and provide constants (py-pdf#3478) by @stefan6419846 [Full Changelog](py-pdf/pypdf@6.1.0...6.1.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some testing has shown that the way we embed files does not allow for PDF/A-3 conformance (tested with PDF/A-3B using veraPDF). Apply the necessary patches to our embedding code and add a basic usage example for the necessary properties to set for an attachment to pass validation.
Includes some small additional cleanup to use
writer.root_objectinstead ofwriter._root_objectand make the test names more readable as well.