fix arrays

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -2935,7 +2935,7 @@ static function (): void {
 $exprResult->getThrowPoints(),
 $exprResult->getImpurePoints(),
 static fn (): MutatingScope => $scope->filterByTruthyValue($expr),
-static fn (): MutatingScope => $scope->filterByFalseyValue($expr)
+static fn (): MutatingScope => $scope->filterByFalseyValue($expr),
 );
 } elseif ($expr instanceof StaticCall) {
 $hasYield = false;
@@ -3247,13 +3247,15 @@ static function (): void {
 $hasYield = $hasYield || $keyResult->hasYield();
 $throwPoints = array_merge($throwPoints, $keyResult->getThrowPoints());
 $impurePoints = array_merge($impurePoints, $keyResult->getImpurePoints());
+$isAlwaysTerminating = $isAlwaysTerminating || $keyResult->isAlwaysTerminating();
 $scope = $keyResult->getScope();
 }
 
 $valueResult = $this->processExprNode($stmt, $arrayItem->value, $scope, $nodeCallback, $context->enterDeep());
 $hasYield = $hasYield || $valueResult->hasYield();
 $throwPoints = array_merge($throwPoints, $valueResult->getThrowPoints());
 $impurePoints = array_merge($impurePoints, $valueResult->getImpurePoints());
+$isAlwaysTerminating = $isAlwaysTerminating || $valueResult->isAlwaysTerminating();
 $scope = $valueResult->getScope();
 }
 $nodeCallback(new LiteralArrayNode($expr, $itemNodes), $scope);

tests/PHPStan/Rules/DeadCode/UnreachableStatementRuleTest.php

@@ -285,6 +285,10 @@ public function testBug13232a(): void
 'Unreachable statement - code above always terminates.',
 32,
 ],
+[
+'Unreachable statement - code above always terminates.',
+40,
+],
 ]);
 }
 

tests/PHPStan/Rules/DeadCode/data/bug-13232a.php

@@ -32,6 +32,13 @@ public function sayHe(): void
 echo 'this will never happen';
 }
 
+public function sayHuu(): void
+{
+$x = [
+$this->neverReturnsMethod()
+];
+echo 'this will never happen';
+}
 
 function neverReturnsMethod(): never {
 exit();