Skip to content

Conversation

@MarvinXu
Copy link

@MarvinXu MarvinXu commented Jan 3, 2024

Description

Showing local time in the log is helpful for debugging. Currently payload doesn't respect env variable TZ by default. We can modify the default loggerOptions a bit to support this, just like Directus did.

image

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation
Copy link
Contributor

@paulpopus paulpopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR to Payload! @MarvinXu

I think this change makes sense to me, it's expected that the server logs by default are in the server's time.

@MarvinXu
Copy link
Author

MarvinXu commented Jan 5, 2024

@paulpopus Thanks! That's very nice to hear! I just started using payloadcms 😁

@DanRibbens DanRibbens merged commit 493fde5 into payloadcms:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants