fix(otlp-transformer): trunc hrTime to int for nanos converting #5924
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This one is for a case I'vs seen in one of our users environments.
In
otlpTransformerpackage,hrTimeToNanosfunction, we feed the components ofhrTimeintoBigIntwhich will throw if the argument is not an integer:Followed all the places where we populate the
hrTimeand honestly I am not sure where this non-integer value is coming from, but it doesn't hurt to verify. If a non-int value is somehow find it's way into a span, then the exception will kill the node process which is a big problem and should be avoided.Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a unit test. Also there is an app which used to crash in one of odigos users environments and after the fix the crashes went away.