Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

Same as the PR in contrib: open-telemetry/opentelemetry-js-contrib#3117
Bumped to lockfile-version=3, regenerated the package-lock.json

I suspect that this will fix the issues in #5976

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (b0c6fab) to head (d25de88).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #5978 +/- ## ======================================= Coverage 95.17% 95.17% ======================================= Files 316 316 Lines 8521 8521 Branches 1763 1763 ======================================= Hits 8110 8110 Misses 411 411 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pichlermarc
Copy link
Member Author

I might have spent a lot of time working through issues on this PR that are likely somehow related to npm/cli#8628. Some optional dependencies did not get installed that used to be there before (like the ones on @bufbuild/buf) - which broke CI here.

@pichlermarc
Copy link
Member Author

not sure what's going on with windows tests though. npm ci never finishes.
Anyway - the first failure is likely caused by the same issue. The optional dependencies for nx were not installed, and therefore the windows binary was missing.

I'll try making out CI use npm@11.6.0 for now to see if that helps.

@pichlermarc
Copy link
Member Author

Opened #5979 to pin to npm@11.6.0 for now.

@pichlermarc pichlermarc marked this pull request as ready for review October 2, 2025 15:36
@pichlermarc pichlermarc requested a review from a team as a code owner October 2, 2025 15:36
@pichlermarc pichlermarc added this pull request to the merge queue Oct 2, 2025
Merged via the queue into open-telemetry:main with commit 06621d2 Oct 2, 2025
25 checks passed
@pichlermarc pichlermarc deleted the chore/lockfile-v3 branch October 2, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants