refactor(otlp-exporter-base): use get*FromEnv() for otlp exporter config #5583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Migrated away from using `process.env` to use the `getStringFromEnv`-function Signed-off-by: Weyert de Boer <wdb@innerfuse.biz>
…tFromEnv`-functions Signed-off-by: Weyert de Boer <wdb@innerfuse.biz>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #5583 +/- ## ========================================== - Coverage 95.07% 95.07% -0.01% ========================================== Files 308 308 Lines 8039 8037 -2 Branches 1627 1626 -1 ========================================== - Hits 7643 7641 -2 Misses 396 396
🚀 New features to boost your workflow:
|
weyert changed the title Signed-off-by: Weyert de Boer <wdb@innerfuse.biz>
weyert commented Apr 6, 2025
...imental/packages/otlp-exporter-base/test/node/configuration/shared-env-configuration.test.ts Show resolved Hide resolved
maryliag changed the title 
trentm previously requested changes Apr 9, 2025
experimental/packages/otlp-exporter-base/src/configuration/shared-env-configuration.ts Outdated Show resolved Hide resolved
experimental/packages/otlp-exporter-base/src/configuration/shared-env-configuration.ts Outdated Show resolved Hide resolved
...imental/packages/otlp-exporter-base/test/node/configuration/shared-env-configuration.test.ts Show resolved Hide resolved
...imental/packages/otlp-exporter-base/test/node/configuration/shared-env-configuration.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Trent Mick <trentm@gmail.com>
pichlermarc approved these changes Sep 9, 2025
Member
pichlermarc left a comment
pichlermarc left a comment There was a problem hiding this comment.
I took the liberty to address the remaining comments and resolve conflicts. This should be good to merge now.
maryliag approved these changes Sep 9, 2025
pichlermarc dismissed trentm’s stale review requested changes were addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Migrated away from using
process.envto use thegetStringFromEnv-functionFixes #5562
Short description of the changes
Replaced the usage of
process.envwith the built-in getEnv utility functionsType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: