Implement embedded-hal 1.0 I2c trait for Twi and Twim #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For some reason suspending causes subsequent reads to overrun.
9names approved these changes Apr 16, 2024
Member
9names left a comment
9names left a comment There was a problem hiding this comment.
Don't have time for a couple of days to test this out again, but logic looks good.
| } | ||
| | ||
| fn write_part(&mut self, buffer: &[u8], final_operation: bool) -> Result<(), Error> { | ||
| unsafe { self.set_tx_buffer(buffer)? }; |
Member Author
There was a problem hiding this comment.
I'm not entirely sure. Added some more fences to be on the safe side.
Member Author
I tested the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
Twiimplementation is untested as I don't have any nrf51 devices.Unfortunately the
Twimimplementation isn't working correctly. Adjacent operations of the same type are specified to be carried out without an SR and SAD+R/W, which is why I avoid setting thelastrx_stoporlasttx_stopshortcut in that case, but when testing this I've found that trying to have two read operations in a row results in an overrun error for some reason.