chore: use @npmcli/template-oss #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2022
lukekarrys added a commit that referenced this pull request Feb 26, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*` on either side causing a decrease in performance when used on range strings with a lot of spaces. Since the result of the split is immediately trimmed, we can just split on the string instead.
lukekarrys force-pushed the lk/update branch from 68c78b6 to e628d22 Compare 
Contributor Author
Closed
lukekarrys force-pushed the lk/update branch 2 times, most recently from f75a170 to 8a3aa0e Compare lukekarrys added a commit that referenced this pull request Mar 25, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*` on either side causing a decrease in performance when used on range strings with a lot of spaces. Since the result of the split is immediately trimmed, we can just split on the string instead.
lukekarrys force-pushed the lk/update branch 2 times, most recently from 23dbd47 to 8ed4b9d Compare lukekarrys added a commit that referenced this pull request Mar 25, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*` on either side causing a decrease in performance when used on range strings with a lot of spaces. Since the result of the split is immediately trimmed, we can just split on the string instead.
lukekarrys added a commit that referenced this pull request Mar 25, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*` on either side causing a decrease in performance when used on range strings with a lot of spaces. Since the result of the split is immediately trimmed, we can just split on the string instead.
lukekarrys force-pushed the lk/update branch 4 times, most recently from 8b4da5f to b9515aa Compare 
Contributor
| This was a breaking change, since it dropped a number of node versions that are included in |
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds
@npmcli/template-ossto manage GitHub Actions, linting, andother chores.
This surfaced a few bugs which I opted to fix in separate issues:
GTE0regexes #432Closes #146
Closes #421
Closes #426
Closes #401
Closes #358