readline: fix unresolved promise on abortion

Fixes: #53497 PR-URL: #54030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Author: DanielVenable

lib/internal/readline/interface.js

@@ -32,12 +32,14 @@ const {
  SafeStringIterator,
 } = primordials;
 
-const { codes } = require('internal/errors');
-
 const {
- ERR_INVALID_ARG_VALUE,
- ERR_USE_AFTER_CLOSE,
-} = codes;
+ AbortError,
+ codes: {
+ ERR_INVALID_ARG_VALUE,
+ ERR_USE_AFTER_CLOSE,
+ },
+} = require('internal/errors');
+
 const {
  validateAbortSignal,
  validateArray,
@@ -111,6 +113,7 @@ const kPrompt = Symbol('_prompt');
 const kPushToKillRing = Symbol('_pushToKillRing');
 const kPushToUndoStack = Symbol('_pushToUndoStack');
 const kQuestionCallback = Symbol('_questionCallback');
+const kQuestionReject = Symbol('_questionReject');
 const kRedo = Symbol('_redo');
 const kRedoStack = Symbol('_redoStack');
 const kRefreshLine = Symbol('_refreshLine');
@@ -1126,6 +1129,7 @@ class Interface extends InterfaceConstructor {
  } else {
  // This readline instance is finished
  this.close();
+ this[kQuestionReject]?.(new AbortError('Aborted with Ctrl+C'));
  }
  break;
 
@@ -1137,6 +1141,7 @@ class Interface extends InterfaceConstructor {
  if (this.cursor === 0 && this.line.length === 0) {
  // This readline instance is finished
  this.close();
+ this[kQuestionReject]?.(new AbortError('Aborted with Ctrl+D'));
  } else if (this.cursor < this.line.length) {
  this[kDeleteRight]();
  }
@@ -1392,6 +1397,7 @@ module.exports = {
  kQuestion,
  kQuestionCallback,
  kQuestionCancel,
+ kQuestionReject,
  kRefreshLine,
  kSawKeyPress,
  kSawReturnAt,

lib/readline/promises.js

@@ -12,6 +12,7 @@ const {
  Interface: _Interface,
  kQuestion,
  kQuestionCancel,
+ kQuestionReject,
 } = require('internal/readline/interface');
 
 const {
@@ -54,6 +55,8 @@ class Interface extends _Interface {
  };
  }
 
+ this[kQuestionReject] = reject;
+
  this[kQuestion](query, cb);
  });
  }

test/parallel/test-readline-promises-interface.js

@@ -948,6 +948,22 @@ for (let i = 0; i < 12; i++) {
  rli.close();
  }
 
+ // Aborting a question with ctrl+C
+ {
+ const [rli, fi] = getInterface({ terminal: true });
+ assert.rejects(rli.question('hello?'), { name: 'AbortError' })
+ .then(common.mustCall());
+ fi.emit('keypress', '.', { ctrl: true, name: 'c' });
+ }
+
+ // Aborting a question with ctrl+D
+ {
+ const [rli, fi] = getInterface({ terminal: true });
+ assert.rejects(rli.question('hello?'), { name: 'AbortError' })
+ .then(common.mustCall());
+ fi.emit('keypress', '.', { ctrl: true, name: 'd' });
+ }
+
  (async () => {
  const [rli] = getInterface({ terminal });
  const signal = AbortSignal.abort('boom');